| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Refactor parse analysis of EXECUTE command |
| Date: | 2019-11-01 07:07:16 |
| Message-ID: | 6e7aa4a1-be6a-1a75-b1f9-83a678e5184a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This patch moves the parse analysis component of ExecuteQuery() and
EvaluateParams() into a new transformExecuteStmt() that is called from
transformStmt(). This makes EXECUTE behave more like other utility
commands.
Effects are that error messages can have position information (see
regression test case), and it allows using external parameters in the
arguments of the EXECUTE command.
I had previously inquired about this in [0] and some vague concerns were
raised. I haven't dug very deep on this, but I figure with an actual
patch it might be easier to review and figure out if there are any problems.
[0]:
https://www.postgresql.org/message-id/flat/ed2767e5-c506-048d-8ddf-280ecbc9e1b7%402ndquadrant.com
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-11-01 08:37:58 | Re: Creating foreign key on partitioned table is too slow |
| Previous Message | Thomas Munro | 2019-11-01 06:58:04 | Re: On disable_cost |