Re: PATCH: recursive json_populate_record()

From: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
To: David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: recursive json_populate_record()
Date: 2017-03-22 16:04:07
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 22.03.2017 00:26, David Steele wrote:

> On 3/21/17 2:31 PM, Andrew Dunstan wrote:
>> On 03/21/2017 01:37 PM, David Steele wrote:
> >>
>>> This thread has been idle for months since Tom's review.
>>> The submission has been marked "Returned with Feedback". Please feel
>>> free to resubmit to a future commitfest.
>> Please revive. I am planning to look at this later this week.
> Revived in "Waiting on Author" state.

Here is updated v05 version of this patch:
* rebased to the latest master
* one patch is completely removed because it is unnecessary now
* added some macros for JsValue fields access
* added new JsObject structure for passing json/jsonb objects
* refactoring patch is not yet simplified (not broken into a
step-by-step sequence)

Also I must notice that json branch of this code is not as optimal as it
might be:
there could be repetitive parsing passes for nested json objects/arrays
instead of a single parsing pass.

Nikita Glukhov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0001-refactor-json_populate_record-v05.patch text/x-patch 36.2 KB
0002-recursive-json_populate_record-v05.patch text/x-patch 73.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-03-22 16:10:07 Re: [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output
Previous Message Simon Riggs 2017-03-22 15:59:42 Re: Logical decoding on standby