Re: PATCH: Unlogged tables re-initialization tests

From: David Steele <david(at)pgmasters(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: PATCH: Unlogged tables re-initialization tests
Date: 2018-03-13 14:12:34
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thanks for reviewing, Peter.

On 3/9/18 5:23 PM, Peter Eisentraut wrote:
> This seems like a useful test.
> On 3/5/18 12:35, David Steele wrote:
>> +mkdir($tablespaceDir)
>> + or die "unable to mkdir \"$tablespaceDir\"";
> Use BAIL_OUT instead of die in tests.


>> + $ts1UnloggedPath = $node->safe_psql('postgres',
>> + q{select pg_relation_filepath('ts1_unlogged')});
> strange indentation

Sure is. Fixed.

>> +# Write forks to test that they are removed during recovery
>> +$node->command_ok(['touch', "$pgdata/${baseUnloggedPath}_vm"],
>> + 'touch vm fork in base');
>> +$node->command_ok(['touch', "$pgdata/${baseUnloggedPath}_fsm"],
>> + 'touch fsm fork in base');
> These are not tests, just some prep work. So they should not use
> command_ok.

Removed command_ok().

> It would probably also be better to avoid the Unix-specific touch
> command and instead use Perl code to open and write to the files.

Updated to use append_to_file().

>> +# Check unlogged table in base
>> +ok(-f "$pgdata/${baseUnloggedPath}_init", 'init fork in base');
>> +ok(-f "$pgdata/$baseUnloggedPath", 'main fork in base');
>> +ok(!-f "$pgdata/${baseUnloggedPath}_vm", 'vm fork not in base');
>> +ok(!-f "$pgdata/${baseUnloggedPath}_fsm", 'fsm fork not in base');
> These test names could be a bit more verbose and distinct, for example,
> 'main fork was recreated after restart'.


A new patch is attached.


Attachment Content-Type Size
recovery-reinit-unlogged-test-v3.patch text/plain 4.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2018-03-13 14:13:05 Re: [HACKERS] Partition-wise aggregation/grouping
Previous Message Aleksander Alekseev 2018-03-13 14:03:09 Re: Google Summer of Code: Potential Applicant