| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Generate pg_stat_get_* functions with Macros |
| Date: | 2022-12-10 08:06:06 |
| Message-ID: | 6aa3ca59-f2b0-0e10-ba3a-a44c4064c8cc@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 12/10/22 4:55 AM, Nathan Bossart wrote:
> On Fri, Dec 09, 2022 at 09:43:56PM -0500, Tom Lane wrote:
>> Presumably it could be silenced by removing the semicolons after
>> the new macro calls:
>
>> The backslash after the last right brace means that the line
>> following that is part of the macro body. This does no harm as
>> long as said line is blank ... but I think it's a foot-gun
>> waiting to bite somebody, because visually you'd think the macro
>> ends with the brace. So I'd leave off that last backslash.
>
> Indeed. Patch attached.
>
Oh right. Thanks Tom for the explanations and Nathan/Michael for the fix.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2022-12-10 08:09:27 | Re: Minimal logical decoding on standbys |
| Previous Message | David Rowley | 2022-12-10 07:32:06 | Speedup generation of command completion tags |