| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Bad bug in fopen() wrapper code |
| Date: | 2006-09-24 17:03:09 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FBDF@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> > Attached patch sets the O_CREAT option when appending to files.
>
> That looks correct, but I went looking to see if there were
> any other mistakes of the same ilk, and I'm wondering what
> the sense is in openFlagsToCreateFileFlags ... seems like
> it's ignoring O_EXCL in some combinations and not others. Is
> that right?
That is part of the original open() code that Claudio did back for 8.0,
so it has definitly been working since then. I haven't really read into
the code, though... But a qiuck look doesn't show me any place wher eit
does ignore O_EXCL - which combination would that be?
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2006-09-24 17:03:38 | Re: pg_regress starting postmaster |
| Previous Message | Tom Lane | 2006-09-24 17:02:20 | Re: pg_regress starting postmaster |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-09-24 17:11:03 | Re: Updates to pg_regress.c |
| Previous Message | Tom Lane | 2006-09-24 17:00:22 | Re: pg_ctl error msg on Windows 2000 |