Re: PATCH: add "--config-file=" option to pg_rewind

From: "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, x4mmm(at)yandex-team(dot)ru, kondratovaleksey(at)gmail(dot)com
Subject: Re: PATCH: add "--config-file=" option to pg_rewind
Date: 2022-03-01 11:35:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Am 01.03.22 um 05:18 schrieb Michael Paquier:
> On Mon, Feb 28, 2022 at 08:48:23PM +0100, Gunnar "Nick" Bluth wrote:
>> So, how should we call the global "find the ***** 'postgres' executable and
>> boil out if that fails" function?
>> char postgres_exec_path[MAXPGPATH] = findPostgresExec();
>> ?
> That would mean only a couple of lines gained, and the readability
> gained is minimal, so I'd be fine to keep the code as-is. I am not
> sure about the full patch set yet, but the refactoring of the commands
> to use PQExpBuffer is good by itself, so I have extracted this part of
> the patch and applied that for now.

Which made the remaining patch v5 (which also appends the --config-file
for ensureCleanShutdown) much cleaner :)

Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
"Ceterum censeo SystemD esse delendam" - Cato

Attachment Content-Type Size
add_configfile_to_pg_rewind_v5.patch text/x-patch 7.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2022-03-01 11:45:46 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Michael Paquier 2022-03-01 11:28:09 Re: Allow file inclusion in pg_hba and pg_ident files