Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)
Date: 2017-03-17 16:23:51
Message-ID: 69213874-32c3-d58d-d057-a5dcdca333c0@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

I'm struggling to find a good way to share code between
bt_page_items(text, int4) and bt_page_items(bytea).

If we do it via the SQL route, as I had suggested, it makes the
extension non-relocatable, and it will also create a bit of a mess
during upgrades.

If doing it in C, it will be a bit tricky to pass the SRF context
around. There is no "DirectFunctionCall within SRF context", AFAICT.

I'm half tempted to just rip out the (text, int4) variants.

In any case, I think we should add bytea variants to all the btree
functions, not just the bt_page_items one.

Attached is the remaining patch after the previous commits.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v3-0001-pageinspect-Add-bt_page_items-function-with-bytea.patch application/x-patch 8.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-03-17 16:28:17 Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver
Previous Message Osahon Oduware 2017-03-17 16:22:05 Re: QGIS Seem To Bypass PostgreSQL/PostGIS User Privileges/Permissions