Re: [PATCH] pg_stat_toast v6

From: "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: [PATCH] pg_stat_toast v6
Date: 2022-01-03 19:40:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Am 03.01.22 um 20:11 schrieb Alvaro Herrera:
> On 2022-Jan-03, Gunnar "Nick" Bluth wrote:
>> 9:38 $ git format-patch PGDG/master -v5 -o ..
>> ../v5-0001-ping-pong-of-thougths.patch
>> ../v5-0002-ping-pong-of-thougths.patch
>> ../v5-0003-adds-some-debugging-messages-in-toast_helper.c.patch
>> ...
> Hmm, in such cases I would suggest to create a separate branch and then
> "git merge --squash" for submission. You can keep your development
> branch separate, with other merges if you want.
> I've found this to be easier to manage, though I don't always follow
> that workflow myself.

Using --stdout does help ;-)

I wonder why "track_toast.sql" test fails on Windows (with "ERROR:
compression method lz4 not supported"), but "compression.sql" doesn't.
Any hints?

Anyway, I shamelessly copied "wait_for_stats()" from the "stats.sql"
file and the tests _should_ now work at least on the platforms with lz4.

v6 attached!
Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
"Ceterum censeo SystemD esse delendam" - Cato

Attachment Content-Type Size
pg_stat_toast_v6.patch text/x-patch 49.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2022-01-03 19:54:18 Re: TYPCATEGORY_{NETWORK,USER} [was Dubious usage of TYPCATEGORY_STRING]
Previous Message Andres Freund 2022-01-03 19:16:09 Re: daitch_mokotoff module