| From: | ls7777 <ls7777(at)yandex(dot)ru> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "orlovmg(at)gmail(dot)com" <orlovmg(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Patch for migration of the pg_commit_ts directory |
| Date: | 2025-10-14 15:53:04 |
| Message-ID: | 689211760456931@mail.yandex.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I applied the diff file.
Deleted the $ts variable.
----------------
Кому: 'ls7777' (ls7777(at)yandex(dot)ru);
Копия: pgsql-hackers(at)postgresql(dot)org, orlovmg(at)gmail(dot)com, amit(dot)kapila16(at)gmail(dot)com;
Тема: Patch for migration of the pg_commit_ts directory;
14.10.2025, 09:27, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>:
Hi,
Thanks for updating the patch.
```
+my ($xid,$ts) = $resold =~ /\s*(\d+)\s*\|(.*)/;
```
Per my understanding $ts is not used here. Can you remove it?
Apart from above, I found some cosmetic issues. Please see attached
my fix which can be applied atop HEAD. Can you check and include if
it is OK?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/html | 1.3 KB |
| v6-Migration-of-the-pg_commit_ts-directory.patch | text/x-diff | 8.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-10-14 16:05:32 | Re: Clarification on Role Access Rights to Table Indexes |
| Previous Message | Nathan Bossart | 2025-10-14 15:51:51 | Re: pageinspect some function no need superuser priv |