Re: [PATCH] Implement INSERT SET syntax

From: David Steele <david(at)pgmasters(dot)net>
To: Gareth Palmer <gareth(at)internetnz(dot)net(dot)nz>, movead li <movead(dot)li(at)highgo(dot)ca>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Implement INSERT SET syntax
Date: 2021-03-03 16:27:26
Message-ID: 678007b3-1faa-f7e0-226b-ed3b44c8af51@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/23/20 8:04 PM, Gareth Palmer wrote:
>
> Thank you for the review, attached is v7 of the patch which should
> apply correcly to HEAD.
>
> This version now uses it's own production rule for the SET clause to
> avoid the issue with MultiAssigmentRef nodes in the targetList.

Ibrar, Movead, you are the reviewers of this patch. Do you think all of
Tom's and Peter's concerns have been addressed?

If so, please mark as Ready for Committer so somebody can have a look.

If not, what remains to be done?

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 'Alvaro Herrera' 2021-03-03 16:34:30 Re: PATCH: Batch/pipelining support for libpq
Previous Message Tom Lane 2021-03-03 16:23:54 Re: Shared memory size computation oversight?