Re: PATCH: two slab-like memory allocators

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, John Gorman <johngorman2(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: two slab-like memory allocators
Date: 2017-02-27 17:46:06
Message-ID: 66e4c315-27a5-b3ce-8435-fcd666b04bb3@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 02/27/2017 06:40 PM, Andres Freund wrote:
> On 2017-02-27 18:04:41 +0100, Petr Jelinek wrote:
>> On 27/02/17 18:00, Andres Freund wrote:
>>>
>>>> FWIW I think the ppc64 machines are failing because of unrelated issue
>>>> (changes to integer timestamps). We should probably look at 32bit machines
>>>> first.
>>>
>>> Don't think so - termite is ppc64 afaics, and the failure doesn't look
>>> integer timestamp related (assert failure is clearly about this, and set
>>> of changed commits *only* include slab related commits).
>>>
>>
>> termite is ppc64 but with 4 byte pointer size according to configure so
>> it might be related to that perhaps?
>
> Uh, ok. I checked the --configure options, but not the actual configure
> output (blame -ENOCOFEE and jetlag). The output makes it fairly likely
> that my StandardChunkHeader theory is valid, so I'll work on a patch to
> clean that up.
>

Thanks. I set up a rpi3 machine (amrv7l) that fails with the same issue,
so if you need to test the patch, let me know.

While building, I've also noticed a bunch of warnings about string
formatting, attached is a patch that that fixes those.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
slab-warnings.patch text/x-diff 887 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-02-27 17:46:08 Re: GUC for cleanup indexes threshold.
Previous Message David Steele 2017-02-27 17:44:05 Re: Creation of "Future" commit fest, named 2017-07