From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: Splitting up guc.c |
Date: | 2022-09-11 02:08:40 |
Message-ID: | 666417.1662862120@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> One part that I have found a bit strange lately about guc.c is that we
> have mix the core machinery with the SQL-callable parts. What do you
> think about the addition of a gucfuncs.c in src/backend/utils/adt/ to
> split things a bit more?
I might be wrong, but I think the SQL-callable stuff makes use
of some APIs that are currently private in guc.c. So we'd have
to expose more API to make that possible. Maybe that wouldn't
be a bad thing, but it seems to be getting beyond the original
idea here. (Note I already had to expose find_option() in
order to get the wal_consistency_checking stuff moved out.)
It's not clear to me that "move the SQL-callable stuff" will
end with a nice API boundary.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-09-11 02:18:33 | Re: Index ordering after IS NULL |
Previous Message | Isaac Morland | 2022-09-11 01:41:54 | Re: why can't a table be part of the same publication as its schema |