Re: Add Information during standby recovery conflicts

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: bdrouvot(at)amazon(dot)com, sawada(dot)mshk(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, masahiko(dot)sawada(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add Information during standby recovery conflicts
Date: 2021-01-08 04:19:18
Message-ID: 665ebdf3-d517-18c6-6b32-06fcdd9d6f83@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/01/08 11:17, Kyotaro Horiguchi wrote:
> At Fri, 8 Jan 2021 01:32:11 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>>
>> Attached is the updated version of the patch. This can be applied to
>> current master.
>>
>> With the patch, for example, if the startup process waited longer than
>> deadlock_timeout for the recovery conflict on the lock, the latter log
>> message in the followings would be additionally output.
>>
>> LOG: recovery still waiting after 1001.223 ms: recovery conflict on
>> lock
>> LOG: recovery finished waiting after 19004.694 ms: recovery conflict
>> on lock
>
> + /*
> + * Emit the log message if recovery conflict on buffer pin was resolved but
> + * the startup process waited longer than deadlock_timeout for it.
>
> The first line is beyond the 80th column.

Thanks for pointing out this! This happened because I forgot to run pgindent
for bufmgr.c. Attached is the updated version of the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
log_recovery_conflict_waits_after_resolve_v3.patch text/plain 6.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-01-08 04:25:38 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Josef Šimánek 2021-01-08 04:15:16 Re: [PATCH] Simple progress reporting for COPY command