Re: Making background psql nicer to use in tap tests

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: Making background psql nicer to use in tap tests
Date: 2023-04-07 13:32:12
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 5 Apr 2023, at 23:44, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> Unless there are objections I plan to get this in before the freeze, in order
> to have better interactive tests starting with 16. With a little bit of
> documentation polish I think it's ready.

When looking at the CFBot failure on Linux and Windows (not on macOS) I noticed
that it was down to the instance lacking IO::Pty.

[19:59:12.609](1.606s) ok 1 - scram_iterations in server side ROLE
Can't locate IO/ in @INC (you may need to install the IO::Pty module) (@INC contains: /tmp/cirrus-ci-build/src/test/perl /tmp/cirrus-ci-build/src/test/authentication /etc/perl /usr/local/lib/i386-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/i386-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/i386-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /usr/share/perl5/IPC/ line 1828.

Skimming the VM creation [0] it seems like it should be though? On macOS the
module is installed inside Cirrus and the test runs fine.

I don't think we should go ahead with a patch that refactors interactive_psql
only to SKIP over it in CI (which is what the tab_completion test does now), so
let's wait until we have that sorted before going ahead.

Daniel Gustafsson


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-04-07 13:32:22 Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler?
Previous Message Masahiko Sawada 2023-04-07 13:28:43 Re: CREATE SUBSCRIPTION -- add missing tab-completes