| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Onder Kalaci <onder(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-10-01 12:37:42 |
| Message-ID: | 658315E9-80D1-4B14-A240-98AC6E948129@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 1 Oct 2018, at 01:19, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Sep 30, 2018 at 10:51:44PM +0900, Michael Paquier wrote:
>> You could have chosen something less complicated, like "ホゲ", which is
>> the equivalent of "foo" in English. Anyway, non-ASCII characters should
>> not be included in the final patch.
Fixed in the attached v16 revision.
> Looking at the refactoring patch 0001, wouldn't signalfuncs.c make a
> better name for the new file? There are already multiple examples of
> this type, like logicalfuncs.c, slotfuncs.c, etc.
I have no strong feelings on this, I was merely using the name that Alvaro
suggested when he brought up the refactoring as an extension of this patch.
signalfuncs.c is fine by me, so I did this rename in the attached revision.
> I have moved this patch set to the next commit fest for now.
Thanks.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Refactor-backend-signalling-code-v16.patch | application/octet-stream | 17.1 KB |
| 0002-Support-optional-message-in-backend-cancel-terminate-v16.patch | application/octet-stream | 23.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maksim Milyutin | 2018-10-01 12:41:38 | Re: Hint to set owner for tablespace directory |
| Previous Message | Liudmila Mantrova | 2018-10-01 12:24:10 | Re: SQL/JSON: documentation |