Re: Small patch for pg_basebackup argument parsing

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ryan Murphy <ryanfmurphy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Small patch for pg_basebackup argument parsing
Date: 2017-10-02 00:36:49
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 18 Sep 2017, at 23:18, Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> wrote:
> On Monday, September 18, 2017 5:13:38 PM CEST Tom Lane wrote:
>> Ryan Murphy <ryanfmurphy(at)gmail(dot)com> writes:
>>> Looked thru the diffs and it looks fine to me.
>>> Changing a lot of a integer/long arguments that were being read directly
>>> via atoi / atol to be read as strings first, to give better error
>>> handling.
>>> This looks good to go to me. Reviewing this as "Ready for Committer".
>>> Thanks for the patch, Pierre!
>> I took a quick look through this and had a few thoughts:
> I agree with your suggestions, I will try to produce a new patch before the
> end of the week.

This patch has been marked as Returned with Feedback as no new version has been
submitted. Please re-submit the new version of this patch to the next commit-
fest when it’s ready.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2017-10-02 00:43:41 Re: [WIP] Zipfian distribution in pgbench
Previous Message Daniel Gustafsson 2017-10-02 00:33:12 Re: Optional message to user when terminating/cancelling backend