| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Devrim Gündüz <devrim(at)gunduz(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: head fails to build on SLES 12 (wal_compression=zstd) |
| Date: | 2022-03-31 15:44:40 |
| Message-ID: | 641010.1648741480@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> Possible responses look like:
> - Use 0 which also means "default" (need to verify that works across versions);
> - Or #ifndef ZSTD_CLEVEL_DEFAULT #define ZSTD_CLEVEL_DEFAULT 3;
> - Add a test for a minimum zstd version v1.3.7. This may be a good idea for
> v15 in any case, since we're using a few different APIs (at least
> ZSTD_compress and ZSTD_compressStream2 and execve(zstd)).
In view of 51c0d186d ("Allow parallel zstd compression"), I agree
that some clarity about the minimum supported version of zstd
seems essential. I don't want to be dealing with threading bugs
in ancient zstd versions. However, why do you suggest 1.3.7 in
particular?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-03-31 15:45:56 | Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages |
| Previous Message | Justin Pryzby | 2022-03-31 15:37:40 | Re: head fails to build on SLES 12 (wal_compression=zstd) |