Re: Control your disk usage in PG: Introduction to Disk Quota Extension

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Haozhou Wang <hawang(at)pivotal(dot)io>
Cc: David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Hubert Zhang <hzhang(at)pivotal(dot)io>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)pivotal(dot)io>
Subject: Re: Control your disk usage in PG: Introduction to Disk Quota Extension
Date: 2020-07-31 19:35:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 1 Jul 2020, at 10:36, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 27 Mar 2020, at 11:22, Haozhou Wang <hawang(at)pivotal(dot)io> wrote:
>> We rebased this patch with the newest master.
> This patch now fails to build according to Travis:
> smgr.c: In function ‘smgrtruncate’:
> smgr.c:578:47: error: passing argument 4 of ‘smgrtruncate_hook’ makes integer from pointer without a cast [-Werror=int-conversion]
> (*smgrtruncate_hook)(reln, forknum, nforks, nblocks);
> ^
> smgr.c:578:47: note: expected ‘BlockNumber {aka unsigned int}’ but argument is of type ‘BlockNumber * {aka unsigned int *}’
> The warning is also present in the Windows build:
> src/backend/storage/smgr/smgr.c(578): warning C4047: 'function' : 'BlockNumber' differs in levels of indirection from 'BlockNumber *' [C:\projects\postgresql\postgres.vcxproj]
> src/backend/storage/smgr/smgr.c(578): warning C4024: 'smgrtruncate_hook' : different types for formal and actual parameter 4 [C:\projects\postgresql\postgres.vcxproj]
> 2 Warning(s)
> Marking the patch as Waiting for Author.

As the thread has stalled and the above compilation issue hasn't been
addressed, I'm marking this entry Returned with Feedback. Feel free to open a
new entry when there is a fixed patch.

cheers ./daniel

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-07-31 19:35:22 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message Robert Haas 2020-07-31 19:23:52 Re: Creating a function for exposing memory usage of backend process