Re: Patch to implement pg_current_logfile() function

From: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
To: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to implement pg_current_logfile() function
Date: 2016-10-29 20:00:08
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

Le 29/10/2016 à 14:38, Karl O. Pinc a écrit :
> On Fri, 28 Oct 2016 10:03:37 +0200
> Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
>> ...
>> v9 of the patch, attached here.
> Attached are 2 more documentation patchs to apply on
> top of your v9 patch.
> patch_pg_current_logfile-v9.diff.doc_current_logfiles
> Explains the current_logfiles file in the
> narrative documentation. It's not like I want
> to toot our horn here. I'm afraid that otherwise
> no one will notice the feature.
> patch_pg_current_logfile-v9.diff.doc_indexes
> Fixes an index entry and add more.
> Regards,
> Karl <kop(at)meme(dot)com>
> Free Software: "You don't pay back, you pay forward."
> -- Robert A. Heinlein

The attached v10 of the current_logfiles patch include your last changes
on documentation but not the patch on v9 about the user-supplied GUC
value. I think the v10 path is ready for committers and that the
additional patch to add src/include/utils/guc_values.h to define user
GUC values is something that need to be taken outside this one. Imo,
thoses GUC values (stderr, csvlog) are not expected to change so often
to require a global definition, but why not, if committers think this
must be done I can add it to a v11 patch.

Best regards,

Gilles Darold
Consultant PostgreSQL -

Attachment Content-Type Size
patch_pg_current_logfile-v10.diff text/x-diff 13.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-10-29 20:31:14 Re: make coverage-html on OS X
Previous Message Tom Lane 2016-10-29 19:23:45 Re: Speed of user-defined aggregates using array_append as transfn