Re: ERROR: could not read block

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: zhouqq(at)cs(dot)toronto(dot)edu, icub3d(at)gmail(dot)com, pgsql-admin(at)postgresql(dot)org
Subject: Re: ERROR: could not read block
Date: 2005-11-16 16:08:30
Message-ID: 6302.1132157310@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Is there anything you would like me to include in my build for my
> test runs, or any steps you would like me to take during the tests?

You might want to insert some debugging elog's into mdread() in md.c,
rather than in its caller smgrread. I'm concerned that by the time
control comes back to smgrread, the Windows last-error might have
been changed; in any case, we'd not know exactly which of the steps
in mdread failed. I'd suggest something like

if (FileSeek(v->mdfd_vfd, seekpos, SEEK_SET) != seekpos)
+ {
+ elog(LOG, "seek failed on relation %u/%u/%u: %d",
+ reln->smgr_rnode.spcNode,
+ reln->smgr_rnode.dbNode,
+ reln->smgr_rnode.relNode,
+ GetLastError());
return false;
+ }

status = true;
if ((nbytes = FileRead(v->mdfd_vfd, buffer, BLCKSZ)) != BLCKSZ)
{
+ elog(LOG, "read failed on relation %u/%u/%u: %d bytes, %d",
+ reln->smgr_rnode.spcNode,
+ reln->smgr_rnode.dbNode,
+ reln->smgr_rnode.relNode,
+ nbytes,
+ GetLastError());
/*
* If we are at or past EOF, return zeroes without complaining. Also
* substitute zeroes if we found a partial block at EOF.

(untested, but something like this should do it)

regards, tom lane

In response to

Browse pgsql-admin by date

  From Date Subject
Next Message Kevin Grittner 2005-11-16 17:22:47 Re: ERROR: could not read block
Previous Message Kevin Grittner 2005-11-16 15:44:04 Re: ERROR: could not read block