Re: Idea: closing the loop for "pg_ctl reload"

From: Jan de Visser <jan(at)de-visser(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Idea: closing the loop for "pg_ctl reload"
Date: 2015-03-03 14:19:34
Message-ID: 6255007.zanCvTFL6C@wolverine
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On March 2, 2015 12:56:23 AM Jan de Visser wrote:
> Here's my first crack at this. Notes:
> 1/ I haven't done the '-W' flag Tom mentions yet.
> 2/ Likewise haven't touched pg_reload_conf()
> 3/ Design details: I introduced a new struct in pg_ctl containing the
> parsed- out data from, with functions to retrieve the data
> and to dispose memory allocated for it. This made the change in do_reload
> fairly straightforward. I think this struct can be used in other places in
> pg_ctl as well, and potentially in other files as well.
> 4/ Question: Can I assume pg_malloc allocated memory is set to zero? If not,
> is it OK to do a memset(..., 0, ...)? I don't have much experience on any
> of the esoteric platforms pgsql supports...

Slight tweaks to better deal with pre-9.5 (6?) servers that don't write the
reload timestamp. I tested with a 9.4 server and it seemed to work...

Also implemented -W/-w. Haven't done pg_reload_conf() yet.

Attachment Content-Type Size
Let_pg_ctl_check_the_result_of_a_postmaster_config_reload.patch text/x-patch 11.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2015-03-03 14:32:16 [patch] PL/Python is too lossy with floats
Previous Message Kevin Grittner 2015-03-03 13:56:19 Re: Weirdly pesimistic estimates in optimizer