Re: pgsql: Cleanup comments/docs around the new shmem request callbacks

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Cleanup comments/docs around the new shmem request callbacks
Date: 2026-07-08 02:26:10
Message-ID: 6223b7dc-bfee-fcff-88d9-13f99b8d4897@xs4all.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Op 7/7/26 om 21:40 schreef Heikki Linnakangas:
> Cleanup comments/docs around the new shmem request callbacks
>
> Make it explicit in the docs that the shmem initialization callbacks
> are called while holding ShmemIndexLock.
>
> Reviewed-by: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
> Discussion: https://www.postgresql.org/message-id/CAExHW5sHs+eSiTDOd14buayc6JbBX=Hm5ssFMBK0Ki9sTGEOuA@mail.gmail.com
> Backpatch-through: 19
>
> Branch
> ------
> REL_19_STABLE
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/a53d6d8aea8fe703d86dd2bdc0a3d86800eca7c3
>
> Modified Files
> --------------
> doc/src/sgml/xfunc.sgml | 4 ++--

Hi,

in doc/src/sgml/xfunc.sgml

the sentence:
"two backends trying to initializing the memory area"

should be:
"two backends trying to initialize the memory area"

Thanks,

Erik

> src/backend/storage/ipc/shmem.c | 7 +++++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Richard Guo 2026-07-08 03:02:40 pgsql: Remove nrm_match parameter from fix_upper_expr
Previous Message Jeff Davis 2026-07-08 01:23:11 pgsql: pg_locale_libc.c: add guards to ctype methods.

Browse pgsql-hackers by date

  From Date Subject
Next Message cca5507 2026-07-08 02:36:38 Re: Do not lock tables in get_tables_to_repack
Previous Message Peter Smith 2026-07-08 02:25:52 Re: Support EXCEPT for ALL SEQUENCES publications