Re: Minor comment update for DELETE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Minor comment update for DELETE
Date: 2005-11-18 15:06:47
Message-ID: 6112.1132326407@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> BTW, I noticed the following comment a few lines down in execMain.c
> (circa line 1564):

> * note: we can't run UPDATE queries with transactions
> * off because UPDATEs are actually INSERTs and our
> * scan will mistakenly loop forever, updating the tuple
> * it just inserted.. This should be fixed but until it
> * is, we don't want to get stuck in an infinite loop
> * which corrupts your database..

> This seems obsolete; I'll remove it shortly barring any objections.

No, this is still correct, note the bootstrap-mode test at the start of
the function.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2005-11-18 19:54:30 DROP OWNED again
Previous Message ron limson 2005-11-18 14:29:01 unsubscribe