| From: | "Robert Haas" <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
| Cc: | "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| Date: | 2008-12-01 15:38:53 |
| Message-ID: | 603c8f070812010738k57b6051fr9a333737122e20c7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Looks good to me, except for a somewhat excessive number of calls to
strlen() on the same input data.
...Robert
On Mon, Dec 1, 2008 at 10:31 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Magnus Hagander wrote:
>> I think I agree with the idea that we should match wildcards only at the
>> beginning of the name *for now*, and then see what people actually
>> request :-) I'm less sure about the single-pathname-component part, but
>> the argument around backwards compatible is certainly a very valid one..
>
> Here's one that (I think) does that. For every step, the code becomes
> simpler - which I like when it comes to security code :)
>
> //Magnus
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-12-01 15:41:16 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| Previous Message | Robert Haas | 2008-12-01 15:34:46 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-12-01 15:41:16 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| Previous Message | Simon Riggs | 2008-12-01 15:35:54 | Re: V2 of PITR performance improvement for 8.4 |