Re: POC, WIP: OR-clause support for indexes

From: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
To: Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, teodor(at)sigaev(dot)ru, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: 2023-07-11 08:47:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 10/7/2023 15:38, Alena Rybakina wrote:
> I agreed with the changes. Thank you for your work.
> I updated patch and added you to the authors.
> I specified Ranier Vilela as a reviewer.
This patch looks much better than earlier. But it definitely needs some
covering with tests. As a first simple approximation, here you can see
the result of regression tests, where the transformation limit is set to
0. See in the attachment some test changes induced by these diffs.

Also, I see some impact of the transformation to other queries:
(NOT x > z) ----> (x <= z)
(((a)::text = 'ab'::text) OR ((a)::text = ANY ('{NULL,cd}'::text[])))
(((a)::text = ANY ('{NULL,cd}'::text[])) OR ((a)::text = 'ab'::text))

Transformations, mentioned above, are correct, of course. But it can be
a sign of possible unstable behavior.

Andrey Lepikhov
Postgres Professional

Attachment Content-Type Size
diff-4.diff text/plain 19.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeevan Chalke 2023-07-11 09:28:51 Re: unrecognized node type while displaying a Path due to dangling pointer
Previous Message Sergei Kornilov 2023-07-11 08:47:16 Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL