| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Julien Tachoires <julien(at)tachoires(dot)me>, dgrowleyml(at)gmail(dot)com |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Bug in CREATE TABLE .. LIKE .. INCLUDING STATISTICS? |
| Date: | 2026-04-21 15:19:36 |
| Message-ID: | 5eb0aa36-f7c2-45a2-bf28-ed441f5fc0bf@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2026-04-16 Th 3:44 AM, Srinath Reddy Sadipiralla wrote:
> Hi Julien,
>
> On Wed, Apr 15, 2026 at 7:47 PM Julien Tachoires <julien(at)tachoires(dot)me>
> wrote:
>
> Hi,
>
> One of our customer is experiencing an issue when executing CREATE
> TABLE
> .. LIKE .. INCLUDING ALL; on 14, the following kind of error happens:
> ERROR: cache lookup failed for attribute X of relation ZZZZZZ
>
> It seems to come from generateClonedExtStatsStmt(): get_attname()
> appears to be called with an attribute number (attnum) that does not
> exist.
>
>
> yeah, i was able to reproduce and also check the flow which is the same
> as you mentioned.
>
>
> Please find attached 2 patches for the master branch, the first
> one adds
> a test that triggers the problem, the 2nd one is an attempt to fix it.
>
>
> I think it's better to write a 4 column test, with this it covers both
> cases of lookup either returning the wrong column name or errors
> out when the attnum does not exist in the child, thoughts?
>
> something like this ....
>
> CREATE TABLE parent_like_stats (a int, b int, c int, d int);
> ALTER TABLE parent_like_stats DROP COLUMN b;
> CREATE STATISTICS s_parent ON a, c FROM parent_like_stats;
> CREATE TABLE child_like_stats (LIKE parent_like_stats INCLUDING
> STATISTICS);
>
> other than this patches LGTM.
>
>
>
OK, here's a version that does that in a combined patch, and adjusts the
function comments to mention we also remap the stxkeys. Releases before
18 will need a little adjustment in the test files.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-attnum-remapping-in-generateClonedExtStatsStm.patch | text/x-patch | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Srinath Reddy Sadipiralla | 2026-04-21 15:56:49 | Re: Bug in CREATE TABLE .. LIKE .. INCLUDING STATISTICS? |
| Previous Message | Daniel Gustafsson | 2026-04-21 14:04:40 | Re: BUG #19457: RE: pgp_sym_encrypt silently accepts non-FIPS ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod |