From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: move collation import to backend |
Date: | 2016-11-29 17:16:37 |
Message-ID: | 5e72e41b-4f62-4bab-f367-7e26c82add70@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 11/12/16 10:38 AM, Andres Freund wrote:
> E.g. what if previously present collations are now unavailable?
You get an error message when you try to use the collation. I think
that is a different class of problems.
>>
>> /*
>> * Also forbid matching an any-encoding entry. This test of course is not
>> * backed up by the unique index, but it's not a problem since we don't
>> * support adding any-encoding entries after initdb.
>> */
>
> Note that this isn't true anymore...
I think this is still correct, because the collation import does not
produce any any-encoding entries (collencoding = -1).
>> +
>> +Datum pg_import_system_collations(PG_FUNCTION_ARGS);
>> +
>> +Datum
>> +pg_import_system_collations(PG_FUNCTION_ARGS)
>> +{
>
> Uh?
Required to avoid compiler warning about missing prototype.
> This function needs to have !superuser permissions revoked, which it
> afaics currently hasn't.
Done.
New patch attached (includes OID change because of conflict).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Add-function-to-import-operation-system-collation.patch | text/x-patch | 13.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-11-29 17:37:06 | Re: Patch: Implement failover on libpq connect level. |
Previous Message | Corey Huinker | 2016-11-29 17:15:51 | Re: PSQL commands: \quit_if, \quit_unless |