| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Hao Wu <hawu(at)pivotal(dot)io> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add test case for sslinfo |
| Date: | 2019-08-16 13:50:19 |
| Message-ID: | 5d4c4245-6cd9-b5d3-29c0-5510e83b869d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-07-08 10:18, Michael Paquier wrote:
> On Mon, Jul 08, 2019 at 02:11:34PM +0800, Hao Wu wrote:
>> Thank you for your quick response! I work on greenplum, and I didn't see
>> this folder(src/test/ssl/ssl) before.
>> I will add more certificates to test and resend again.
>
> Not having duplicates would be nice.
I think sslinfo should be tested as an extension of src/test/ssl/
instead of its own test suite. There are too many complications that we
would otherwise have to solve again.
You might want to review commit f60a0e96778854ed0b7fd4737488ba88022e47bd
and how it adds test cases. You can't just hardcode a specific output
since different installations might report TLS 1.2 vs 1.3, different
ciphers etc.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2019-08-16 14:12:02 | Re: Global temporary tables |
| Previous Message | Bruce Momjian | 2019-08-16 13:31:55 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |