Re: consider -Wmissing-variable-declarations

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: consider -Wmissing-variable-declarations
Date: 2024-06-18 07:41:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Here is an updated patch set. I have implemented proper solutions for
the various hacks in the previous patch set. So this patch set should
now be ready for proper consideration.

The way I have organized it here is that patches 0002 through 0008
should be improvements in their own right.

The remaining two patches 0009 and 0010 are workarounds that are just
necessary to satisfy -Wmissing-variable-declarations. I haven't made up
my mind if I'd want to take the bison patch 0010 like this and undo it
later if we move to pure parsers everywhere, or instead wait for the
pure parsers to arrive before we install -Wmissing-variable-declarations
for everyone.

Obviously, people might also have opinions on some details of where
exactly to put the declarations etc. I have tried to follow existing
patterns as much as possible, but those are also not necessarily great
in all cases.

Attachment Content-Type Size
v2-0001-Add-Wmissing-variable-declarations-to-the-standar.patch text/plain 8.0 KB
v2-0002-Convert-some-extern-variables-to-static.patch text/plain 29.5 KB
v2-0003-Add-missing-includes.patch text/plain 2.4 KB
v2-0004-Improve-some-global-variable-declarations.patch text/plain 5.5 KB
v2-0005-Fix-warnings-from-Wmissing-variable-declarations-.patch text/plain 3.9 KB
v2-0006-Get-rid-of-a-global-variable.patch text/plain 4.1 KB
v2-0007-Fix-Wmissing-variable-declarations-warnings-for-G.patch text/plain 9.3 KB
v2-0008-Remove-useless-extern-keywords.patch text/plain 3.3 KB
v2-0009-Fix-Wmissing-variable-declarations-warnings-for-f.patch text/plain 1.1 KB
v2-0010-Fix-Wmissing-variable-declarations-warnings-in-bi.patch text/plain 4.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2024-06-18 07:48:37 Re: Conflict Detection and Resolution
Previous Message Sven Klemm 2024-06-18 07:32:30 Re: [PATCH] Improve error message when trying to lock virtual tuple.