Re: Remove redundant variable pageSize in gistinitpage

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove redundant variable pageSize in gistinitpage
Date: 2021-06-25 06:03:13
Message-ID: 5c9107fd-bb16-0dee-fd56-6131685dcf87@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 26.04.21 05:12, Bharath Rupireddy wrote:
> In gistinitpage, pageSize variable looks redundant, instead we could
> just pass BLCKSZ. This will be consistent with its peers
> BloomInitPage, brin_page_init and SpGistInitPage. Attaching a small
> patch. Thoughts?

Committed.

This code was new in this form in PG14
(16fa9b2b30a357b4aea982bd878ec2e5e002dbcc), so it made sense to clean it
up now.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message zhangjie2@fujitsu.com 2021-06-25 06:15:59 RE: [Patch] change the default value of shared_buffers in postgresql.conf.sample
Previous Message Craig Ringer 2021-06-25 04:51:45 Adding more PGDLLIMPORTs