evtcache: EventTriggerCache vs Event Trigger Cache

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: evtcache: EventTriggerCache vs Event Trigger Cache
Date: 2023-05-04 11:38:26
Message-ID: 5EDC969E-CAE3-4CBD-965E-3B8A1294CFA4@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When reading a memory contexts log I realized that we have this:

LOG: level: 2; EventTriggerCache: 8192 total in 1 blocks; 7928 free (4 chunks); 264 used
LOG: level: 3; Event Trigger Cache: 8192 total in 1 blocks; 2616 free (0 chunks); 5576 used

The reason is that BuildEventTriggerCache sets up a context "EventTriggerCache"
which house a hash named "Event Trigger Cache" which in turn creates a context
with the table name. I think it makes sense that these share the same name,
but I think it would be less confusing if they also shared the same spelling
whitespace-wise. Any reason to not rename the hash EventTriggerCache to make
the logging a tiny bit easier to read and grep?

--
Daniel Gustafsson

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-05-04 12:09:12 Re: evtcache: EventTriggerCache vs Event Trigger Cache
Previous Message Alvaro Herrera 2023-05-04 10:44:01 Re: "variable not found in subplan target list"