| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <jchampion(at)timescale(dot)com>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files |
| Date: | 2023-07-19 23:16:45 |
| Message-ID: | 5E11C21A-D3D9-4655-B208-4BFF310AF551@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 17 Jul 2023, at 10:29, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jul 14, 2023 at 03:07:08PM +0200, Daniel Gustafsson wrote:
>> Judging by the thread there seems to be concensus on skipping .DS_Store files
>> in all branches, with a few +1's for skipping all hidden files in HEAD. I'll
>> prepare a patch for the former and we can pick up the discussion on the latter
>> ones that's done.
>
> Yes, I am also getting that this is the consensus reached here.
Attached is a version that just skips .DS_Store files as per the discussion
here. I opted for not testing this on macOS since I don't want to create
invalid .DS_Store files where they potentially can be seen by the Finder
causing unwanted side effects.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Skip-.DS_Store-files-in-server-side-utils.patch | application/octet-stream | 7.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-07-20 00:11:18 | Re: BUG #18030: Large memory consumption caused by in-clause subqueries |
| Previous Message | David Rowley | 2023-07-19 23:13:05 | Re: BUG #18030: Large memory consumption caused by in-clause subqueries |