Re: A few new options for vacuumdb

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A few new options for vacuumdb
Date: 2019-01-21 22:09:09
Message-ID: 5C971918-E566-41AB-895A-C4793D56B041@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's a new patch set that should address the feedback in this
thread. The changes in this version include:

- 0001 is a small fix to the 'vacuumdb --disable-page-skipping'
documentation. My suggestion is to keep it short and simple like
--full, --freeze, --skip-locked, --verbose, and --analyze. The
DISABLE_PAGE_SKIPPING option is well-described in the VACUUM
documentation, and IMO it is reasonably obvious that such vacuumdb
options correspond to the VACUUM options.
- v3-0002 is essentially v2-0001 and v2-0004 combined. I've also
added a comment explaining the importance of fully qualifying the
catalog query used to discover tables to process.
- 0003 includes additional documentation changes explaining the main
uses of --min-xid-age and --min-mxid-age and linking to the
existing wraparound documentation.

As discussed, I've left out the patch for --min-relation-size for now.

Nathan

Attachment Content-Type Size
v3-0001-Adjust-documentation-for-vacuumdb-disable-page-sk.patch application/octet-stream 1000 bytes
v3-0002-Always-use-a-catalog-query-to-discover-tables-to-.patch application/octet-stream 10.3 KB
v3-0003-Add-min-xid-age-and-min-mxid-age-options-to-vacuu.patch application/octet-stream 6.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-01-21 22:15:45 Re: COPY FROM WHEN condition
Previous Message John Naylor 2019-01-21 22:04:05 is there a reason we don't xlog index free space?