Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw
Date: 2018-01-18 07:16:35
Message-ID: 5A6049D3.4090102@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

(2018/01/17 22:00), Stephen Frost wrote:
> Reviewing this thread, I tend to agree with Etsuro and I'm not sure I
> see where there's a good argument for having a foreign table under a
> view behave differently than a local table under a view for WCO (which
> is an option of the view- not about the table underneath it or if it's
> local or remote). I've not done a detailed review of the patch but it
> seems pretty reasonable and pretty small.

Thanks for the comments!

I noticed the patch doesn't apply. Attached is a rebased patch.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
fix-wco-handling-in-postgres-fdw-v2.patch text/x-diff 18.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2018-01-18 07:18:31 Re: [HACKERS] Useless code in ExecInitModifyTable
Previous Message Tom Lane 2018-01-18 06:47:46 Re: master make check fails on Solaris 10