Re: [PATCH] Implement INSERT SET syntax

From: Gareth Palmer <gareth(at)internetnz(dot)net(dot)nz>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Implement INSERT SET syntax
Date: 2019-08-16 01:21:01
Message-ID: 5A15D0E2-9E43-457F-9560-189C055B6C46@internetnz.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Ibrar,

> On 16/08/2019, at 7:14 AM, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
>
> Patch conflict with this assertion
> Assert(pstate->p_expr_kind == EXPR_KIND_UPDATE_SOURCE);
>
> src/backend/parser/parse_expr.c line 1570
>
> The new status of this patch is: Waiting on Author

Thank-you for reviewing the patch.

Attached is version 2 of the patch that fixes the above by allowing
p_expr_kind to be EXPR_KIND_VALUES_SINGLE as well.

Gareth

Attachment Content-Type Size
insert-set-v2.patch application/octet-stream 10.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-08-16 01:28:15 Re: Add "password_protocol" connection parameter to libpq
Previous Message Stephen Frost 2019-08-16 01:01:05 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)