| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org>, Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
| Subject: | Re: pg_restore -F bug |
| Date: | 2005-04-29 14:40:43 |
| Message-ID: | 5870.1114785643@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Neil Conway <neilc(at)samurai(dot)com> writes:
> This patch fixes a bug in the error message emitted by pg_restore on an
> incorrect -F argument: write_msg() expects its first parameter to be a
> "module name", not the format string. Patch applied to HEAD. Is this
> worth backporting?
Certainly --- particularly if the error makes it dump core, as seems
likely (haven't tried it).
> BTW, is there a reason that pg_restore seems to accept 'f', 't', or 'c'
> parameters to this argument, but the documentation only documents 't'
> and 'c'?
I think the 'f' option is only intended for debugging purposes ...
Philip would know ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthew T. O'Connor | 2005-04-29 15:40:13 | Re: Feature freeze date for 8.1 |
| Previous Message | Bruce Momjian | 2005-04-29 14:09:43 | Re: Feature freeze date for 8.1 |