Re: [PATCH] kNN for btree

From: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] kNN for btree
Date: 2018-11-30 12:04:34
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 29.11.2018 18:24, Dmitry Dolgov wrote:
>> On Wed, Sep 26, 2018 at 5:41 PM Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> wrote:
>> Attached 3rd version of the patches rebased onto the current master.
>> Changes from the previous version:
>> - Added support of INCLUDE columns to get_index_column_opclass() (1st patch).
>> - Added parallel kNN scan support.
>> - amcanorderbyop() was transformed into ammatchorderby() which takes a List of
>> PathKeys and checks each of them with new function match_orderbyop_pathkey()
>> extracted from match_pathkeys_to_index(). I think that this design can be
>> used in the future to support a mix of ordinary and order-by-op PathKeys,
>> but I am not sure.
> Hi,
> Unfortunately, the patch has some conflicts, could you rebase it? In the
> meantime I'll move it to the next CF, hoping to have more reviewers for this
> item.

Attached 4th version of the patches rebased onto the current master.

Nikita Glukhov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0001-Fix-get_index_column_opclass-v04.patch text/x-patch 1.6 KB
0002-Introduce-ammatchorderby-function-v04.patch text/x-patch 21.8 KB
0003-Extract-structure-BTScanState-v04.patch text/x-patch 43.7 KB
0004-Add-kNN-support-to-btree-v04.patch text/x-patch 60.3 KB
0005-Add-btree-distance-operators-v04.patch text/x-patch 80.0 KB
0006-Remove-distance-operators-from-btree_gist-v04.patch text/x-patch 102.6 KB
0007-Add-regression-tests-for-kNN-btree-v04.patch text/x-patch 29.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kuzmenkov 2018-11-30 12:07:59 Re: "SELECT ... FROM DUAL" is not quite as silly as it appears
Previous Message Arthur Zakirov 2018-11-30 11:18:04 Re: Add extension options to control TAP and isolation tests