Re: Docbook 5.x

From: Alexander Law <exclusion(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, obartunov(at)gmail(dot)com, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Lakhin <a(dot)lakhin(at)postgrespro(dot)ru>
Cc: Jürgen Purtz <juergen(at)purtz(dot)de>, pgsql-docs(at)postgresql(dot)org
Subject: Re: Docbook 5.x
Date: 2016-06-04 14:28:41
Message-ID: 5752E599.2090505@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Hello Peter,

Thanks for improvements!
I checked outputs (with the attached script) and found that there is
small difference with the improved patch.
For example, look at xtypes.html:

- <link rel="home" href="index.html" title="PostgreSQL 9.6beta1
Documentation" /><link rel="up" href="extend.html"
title="Chapter 35. Extending SQL" /><link rel="prev" href="xaggr.html"
title="35.10. User-defined Aggregates" /><link rel="next"
href="xoper.html" title="35.12. User-defined Operators" /><link
rel="copyright" href="legalnotice.html" title="Legal Notice" /></head>

+ <link rel="prev" href="xaggr.html" title="35.10. User-defined
Aggregates" /><link rel="next" href="xoper.html"
title="35.12. User-defined Operators" /></head>

It caused by <xsl:template name="html.head">.
Leaving aside the question whether the links "home", "up" and
"copyright" are needed, maybe it's better to split the commit to two?
First to speed up the conversion while making sure that the output is
the same, and the second to change the html.head output format.

Best regards,
Alexander

03.06.2016 22:31, Peter Eisentraut пишет:
> On 5/5/16 12:45 AM, Alexander Law wrote:
>> Done (previous patch cleaned).
>> This patch optimizes XSL transformations contained in docbook-xsl
>> (1.78.1).
>
> I have looked through this patch, and it's awesome. I have tweaked it
> a bit more along the lines you guys have started, and now the build
> time is pretty much the same as with DSSSL. Attached is my final
> patch, which I plan to commit as soon as the new branch opens.
>
> (I only have Alexander Lakhin as credit right now. Please let me know
> if anyone else contributed.)
>

Attachment Content-Type Size
check_patch.sh application/x-shellscript 2.1 KB

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message npistud 2016-06-06 05:40:56 Math function description issue
Previous Message gp0072000 2016-06-04 07:28:02 Typo