| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tristan Partin <tristan(at)neon(dot)tech>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, gdo(at)leader(dot)it, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| Date: | 2023-06-10 19:28:47 |
| Message-ID: | 574a1afa-5c6e-829c-0fed-a9ff44719f9f@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 6/10/23 15:07, Joe Conway wrote:
> On 6/10/23 14:42, Tom Lane wrote:
>> Joe Conway <mail(at)joeconway(dot)com> writes:
>>> 5/ The attached fixes the issue for me on pg10 and passes check-world.
>>> Comments?
>>
>> The call in PGLC_localeconv seems *very* oddly placed. Why not
>> do that before it does any other locale calls? Otherwise you don't
>> really have reason to believe you're saving the appropriate
>> values to restore later.
>
>
> As far as I can tell it really only affects localeconv(), so I tried to
> place it close to those. But I am fine with moving it up.
This version is against pg16 (rather than pg10), moves up that hunk,
mentions localeconv() in the comment as the reason for the call, and
fixes some whitespace sloppiness. I will plan to apply to all supported
branches.
Better?
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| 20230610-plperl_locale_issue-001.patch | text/x-patch | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-06-10 19:32:36 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| Previous Message | Joe Conway | 2023-06-10 19:07:05 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-06-10 19:32:36 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |
| Previous Message | Joe Conway | 2023-06-10 19:07:05 | Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG |