Re: this patch correct upper and lower case for translated month's and day's names

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: this patch correct upper and lower case for translated month's and day's names
Date: 2006-11-29 23:13:54
Message-ID: 5743.1164842034@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> this patch correct bug in to_char function with incorrect uppercased month's
> or day's name.

I still think this coding is unsafe in the case where the modified
string is longer than the original. Also, could we please not duplicate
such a large chunk of code between here and oracle_compat.c?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2006-11-29 23:32:26 Re: this patch correct upper and lower case for translated month's and
Previous Message Pavel Stehule 2006-11-29 23:06:03 this patch correct upper and lower case for translated month's and day's names

Browse pgsql-patches by date

  From Date Subject
Next Message Pavel Stehule 2006-11-29 23:32:26 Re: this patch correct upper and lower case for translated month's and
Previous Message Pavel Stehule 2006-11-29 23:06:03 this patch correct upper and lower case for translated month's and day's names