Re: row filtering for logical replication

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>
Cc: Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2021-03-25 11:15:56
Message-ID: 57373e8b-1264-cd37-404e-8edbcf7884cc@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22.03.21 03:15, Euler Taveira wrote:
> I attached a new patch set that addresses:
>
> * fix documentation;
> * rename PublicationRelationQual to PublicationRelationInfo;
> * remove the memset that was leftover from a previous patch set;
> * add new tests to improve coverage (INSERT/UPDATE/DELETE to exercise
> the row
>   filter code).

I have committed the 0001 patch.

Attached are a few fixup patches that I recommend you integrate into
your patch set. They address backward compatibility with PG13, and a
few more stylistic issues.

I suggest you combine your 0002, 0003, and 0004 patches into one. They
can't be used separately, and for example the psql changes in patch 0003
already appear as regression test output changes in 0002, so this
arrangement isn't useful. (0005 can be kept separately, since it's
mostly for debugging right now.)

Attachment Content-Type Size
0001-fixup-Row-filter-for-logical-replication.patch text/plain 1.6 KB
0002-fixup-Row-filter-for-logical-replication.patch text/plain 3.2 KB
0003-fixup-Row-filter-for-logical-replication.patch text/plain 2.1 KB
0004-fixup-Row-filter-for-logical-replication.patch text/plain 1.6 KB
0005-fixup-Publication-WHERE-condition-support-for-pg_dum.patch text/plain 1.9 KB
0006-fixup-Print-publication-WHERE-condition-in-psql.patch text/plain 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-03-25 11:26:10 Re: shared-memory based stats collector
Previous Message Amit Kapila 2021-03-25 11:02:31 Re: [HACKERS] logical decoding of two-phase transactions