Accidentally parallel unsafe functions

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Accidentally parallel unsafe functions
Date: 2016-04-29 22:06:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I am currently looking into adding the correct parallel options to all
functions in the extensions and I noticed that some built-in functions
seems to have been marked as unsafe by accident. The main culprit is
system_views.sql which redefines these functions and removes the
parallel safe flag.

I think this counts as a 9.6 bug unlike my work on adding the flags to
all extensions which is for 9.7.

I have attached a patch which marks them and all conversion functions as
parallel safe. I also added the flag to ts_debug() when I was already
editing system_views.sql, feel free to ignore that one if you like.

Affected functions:

- json_populate_record()
- json_populate_recordset()
- jsonb_insert()
- jsonb_set()
- make_interval()
- parse_ident()
- Loads of conversion functions


Attachment Content-Type Size
parallel-unsafe-functions.patch text/x-patch 4.1 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2016-04-29 22:08:49 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Previous Message Alvaro Herrera 2016-04-29 21:23:40 Re: [COMMITTERS] pgsql: Support building with Visual Studio 2015