Re: WIP: Covering + unique indexes.

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Subject: Re: WIP: Covering + unique indexes.
Date: 2016-04-12 16:14:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Attached version has fix of pg_dump suggested by Stephen
in -committers thread.
Sooner or later, I'd like to see this patch finished.

For now, it has two complaints:
- support of expressions as included columns.
Frankly, I don't understand, why it's a problem of the patch.
The patch is already big enough and it will be much easier to add
expressions support in the following patch, after the first one will be
I wonder, if someone has objections to that?
Yes, it's a kind of delayed feature. But should we wait for every patch
when it will be entirely completed?

- lack of review and testing
Obviously I did as much testing as I could.
So, if reviewers have any concerns about the patch, I'm waiting forward
to see them.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
including_columns_9.7_1.patch text/x-patch 136.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2016-04-12 16:23:24 Re: Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0
Previous Message Andres Freund 2016-04-12 16:02:46 Re: Move PinBuffer and UnpinBuffer to atomics