Re: Optimization for updating foreign tables in Postgres FDW

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Thom Brown <thom(at)linux(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Optimization for updating foreign tables in Postgres FDW
Date: 2016-04-11 08:16:00
Message-ID: 570B5D40.6080203@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2016/04/11 12:30, Michael Paquier wrote:
> + if ((cancel = PQgetCancel(entry->conn)))
> + {
> + PQcancel(cancel, errbuf, sizeof(errbuf));
> + PQfreeCancel(cancel);
> + }
> Wouldn't it be better to issue a WARNING here if PQcancel does not succeed?

Seems like a good idea. Attached is an updated version of the patch.

Thanks for the review!

Best regards,
Etsuro Fujita

Attachment Content-Type Size
pgfdw-direct-modify-v5.patch text/x-patch 3.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2016-04-11 08:52:24 Re: Support for N synchronous standby servers - take 2
Previous Message Michael Paquier 2016-04-11 07:47:21 Re: VS 2015 support in src/tools/msvc