Re: Odd oid-system-column handling in postgres_fdw

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Odd oid-system-column handling in postgres_fdw
Date: 2016-04-05 08:15:22
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2016/03/16 16:25, Etsuro Fujita wrote:
> PG9.5 allows us to add an oid system column to foreign tables, using
> ALTER FOREIGN TABLE SET WITH OIDS, but currently, that column reads as
> zeroes in postgres_fdw. That seems to me like a bug. So, I'd like to
> propose to fix that, by retrieving that column from the remote server
> when requested. I'm attaching a proposed patch for that.

I rebased the patch against HEAD. Updated patch attached. I don't
think this is a 9.6 issue, but I think this is somewhat related to the
9.6 issue [1] that postgres_fdw join pushdown incorrectly retrieves
system columns other than ctid and oid from the remote server, so ISTM
that it's better to address this in conjunction with [1].

Best regards,
Etsuro Fujita


Attachment Content-Type Size
postgres-fdw-oid-support-v2.patch text/x-patch 7.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2016-04-05 08:34:06 Typo in src/interfaces/libpq/fe-connect.c
Previous Message Andres Freund 2016-04-05 08:00:13 Re: Timeline following for logical slots