Re: [PATCH] Phrase search ported to 9.6

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Cc: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, a(dot)korotkov(at)postgrespro(dot)ru, David Steele <david(at)pgmasters(dot)net>
Subject: Re: [PATCH] Phrase search ported to 9.6
Date: 2016-03-31 16:36:53
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Looking at patch, I'm inlined to commit it in current commitfest, it looks
workable and too many people desire it. I've did some changes, mostly in
formatting and comments.

Patch makes some user-visible changes:
1 change order for tsquery. Assume, it's acceptable, only a few users store
tsquery in table and have a Btree index. They will need to reindex.
2 less number of parenthesis in tsquery output, and tsquery becomes more readable.

Pls, remove tsquery_setweight from patch because it's not a part of phrase
search and it isn't mentioned in docs. Please, make a separate patch for it.

Dmitry Ivanov wrote:
> Sorry for the delay, I desperately needed some time to finish a bunch of
> dangling tasks.
> I've added some new comments and clarified the ones that were obscure.
> Moreover, I felt an urge to recheck most parts of the code since apparently
> nobody (besides myself) has gone so far yet.
> On 25.03.16 18:42 MSK, David Steele wrote:
>> Time is short and it's not encouraging that you say there is "still much
> work to be done".
> Indeed, I was inaccurate. I am more than interested in the positive outcome.

Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru

Attachment Content-Type Size
phrase-0.4.patch binary/octet-stream 136.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robbie Harwood 2016-03-31 17:04:32 Re: [PATCH v9] GSSAPI encryption support
Previous Message Andres Freund 2016-03-31 16:14:49 Re: Move PinBuffer and UnpinBuffer to atomics