Re: IF (NOT) EXISTS in psql-completion

From: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: David Steele <david(at)pgmasters(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: IF (NOT) EXISTS in psql-completion
Date: 2016-03-29 09:54:01
Message-ID: 56FA50B9.7000107@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 29.03.2016 10:59, Pavel Stehule wrote:
> Hi
>
> 2016-03-29 8:43 GMT+02:00 Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp <mailto:horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>>:
>
> Thank you Pavel, David.
>
> Thank you for pointing syntaxes to be addressed. Most of the are
> addressed in the attached patch.
>
>
> At Tue, 22 Mar 2016 12:57:27 -0400, David Steele
> <david(at)pgmasters(dot)net <mailto:david(at)pgmasters(dot)net>> wrote in
> <56F17977(dot)8040503(at)pgmasters(dot)net <mailto:56F17977(dot)8040503(at)pgmasters(dot)net>>
> > Hi Kyotaro,
> >
> > On 3/18/16 3:22 AM, Pavel Stehule wrote:
> >
> > > I am looking this patch. It looks well, but this feature doesn't
> > > respect upper or lower chars. It enforce upper chars. This is not
> > > consistent with any other autocomplete.
>
> As mentioned before, upper-lower problem is an existing
> issue. The case of the words in a query result list cannot be
> edited since it may contain words that should not be changed,
> such as relation names. So we can address it only before issueing
> a query but I haven't found simple way to do it.
>
>
> This is unpleasant. I am sorry. I had very uncomfortable feeling from
> this behave. I am thinking so it should be solvable - you have to
> convert only keyword IF EXISTS or IF NOT EXISTS. Maybe there are not
> trivial solution, but this should be fixed.
>

Hello,

Can we do something like in the patch? This patch should be applied
after the patch
"0001-Suggest-IF-NOT-EXISTS-for-tab-completion-of-psql_v3.patch".

--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
tab-complete.patch text/x-patch 1004 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-03-29 10:08:06 Re: IF (NOT) EXISTS in psql-completion
Previous Message John R Pierce 2016-03-29 09:35:01 Re: pg_largeobject