Re: BUG #13440: unaccent does not remove all diacritics

From: Léonard Benedetti <benedetti(at)mlpo(dot)fr>
To: PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13440: unaccent does not remove all diacritics
Date: 2016-03-10 14:44:17
Message-ID: 56E18841.2000406@mlpo.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

10/03/2016 15:35, Léonard Benedetti wrote:
> Le 10/03/2016 14:46, Teodor Sigaev a écrit :
>>> On the other hand, UTF-8 encoding for source code is *a feature of
>>> Python 3* (to quote the documentation: “The default encoding for Python
>>> source code is UTF-8”) so there is no possible ambiguity, and it will
>>> not be a problem. That said, some non-ASCII characters may be removed
>>> without prejudice from the source code of the script (I think in
>>> particular to "“" and "”"). Nevertheless, for some comments, it would be
>>> unfortunate (e.g. “# RegEx to parse rules (e.g. “Đ → D ; […]”)” or “# ℃
>>> °C”).
>> Ok, I didn't know that.
>>
>>
>>> Thus, I propose to adapt the code to Python 3 (the encoding of the
>>> script does not seem to be a problem for the above reasons). I try to do
>>> it shortly.
>> We are waiting...
>>
> Sorry for the delay, adaptation to Python 3 was very easy (the code is
> almost identical).
>
> As usual, you will find attached the new version of the script and the
> generated output for convenience.
>
> Léonard Benedetti
Here is the patch, attached.

Léonard Benedetti

Attachment Content-Type Size
improve-unaccent-default-rules-generation-script-v3.patch text/x-patch 15.7 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Dmitriy Sarafannikov 2016-03-10 14:49:18 Too many files in pg_replslot folder
Previous Message Lucas Souza Cruz 2016-03-10 14:44:06 Performance Improvement in SQL