Re: Optimization for updating foreign tables in Postgres FDW

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Optimization for updating foreign tables in Postgres FDW
Date: 2016-01-12 11:26:01
Message-ID: 5694E2C9.9090107@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 2016/01/07 21:45, Etsuro Fujita wrote:
> On 2016/01/06 18:58, Rushabh Lathia wrote:
>> .) Documentation for the new API is missing (fdw-callbacks).

> Will add the docs.

I added docs for new FDW APIs.

Other changes:

* Rename relation_has_row_level_triggers to relation_has_row_triggers
shortly, and move it to rewriteHandler.c. I'm not sure rewriteHandler.c
is a good place for that, though.

* Revise code, including a helper function get_result_result, whcih I
implemented using a modified version of store_returning_result in the
previous patch, but on second thought, I think that that is a bit too
invasive. So, I re-implemented that function directly using
make_tuple_from_result_row.

* Add more comments.

* Add more regression tests.

Attached is an updated version of the patch. Comments are wellcome!
(If the fix [1] is okay, I'd like to update this patch on top of the
patch in [1].)

Best regards,
Etsuro Fujita

[1] http://www.postgresql.org/message-id/568F4430.6060805@lab.ntt.co.jp

Attachment Content-Type Size
fdw-dml-pushdown-v3.patch application/x-patch 93.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vladimir Sitnikov 2016-01-12 11:26:27 Re: Re: 9.4-1207 behaves differently with server side prepared statements compared to 9.2-1102
Previous Message Pavel Stehule 2016-01-12 11:25:03 Re: Question about DROP TABLE