Re: Speedup twophase transactions

From: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>
Cc: Alvaro Herrera <alvherre(at)2ndQuadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speedup twophase transactions
Date: 2016-01-11 18:40:03
Message-ID: 5693F703.3000009@redhat.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 01/09/2016 10:29 AM, Simon Riggs wrote:
> On 9 January 2016 at 12:26, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
>
>
>> I’ve updated patch and wrote description of thighs that happens
>> with 2PC state data in the beginning of the file. I think now this patch
>> is well documented,
>> but if somebody points me to places that probably requires more detailed
>> description I’m ready
>> to extend that.
>>
>
> Hmm, I was just preparing this for commit.
>
> Please have a look at my mild edits and extended comments.
>

I have done a run with the patch and it looks really great.

Attached is the TPS graph - with a 1pc run too - and the perf profile as
a flame graph (28C/56T w/ 256Gb mem, 2 x RAID10 SSD).

Maybe

+static void
+XlogReadTwoPhaseData(XLogRecPtr lsn, char **buf, int *len)

to

+static void
+ReadTwoPhaseDataFromXlog(XLogRecPtr lsn, char **buf, int *len)

Best regards,
Jesper

Attachment Content-Type Size
image/png 19.1 KB
xa.svg.gz application/gzip 188.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-01-11 18:41:50 Re: proposal: PL/Pythonu - function ereport
Previous Message Pavel Stehule 2016-01-11 18:33:46 Re: proposal: PL/Pythonu - function ereport